Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated contributing steps for next-server (#5405) #5518

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Updated contributing steps for next-server (#5405) #5518

merged 1 commit into from
Oct 25, 2018

Conversation

michaeljonathanblack
Copy link

Fixes #5405

HaNdTriX
HaNdTriX reviewed Oct 25, 2018
View reviewed changes
Copy link
Contributor

@HaNdTriX HaNdTriX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under to hood next.js uses a feature called yarn workspaces to link the different packages. Documenting these might simplify this setup.

https://yarnpkg.com/lang/en/docs/workspaces/

@timneutkens timneutkens merged commit dfe7c46 into vercel:canary Oct 25, 2018
@timneutkens
Copy link
Member

I think this is fine

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HaNdTriX HaNdTriX HaNdTriX left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contributing.md out of date
3 participants
@michaeljonathanblack @timneutkens @HaNdTriX