Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent name for App Router tests #56352

Merged
merged 2 commits into from
Oct 6, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/app-dir/app-css-pageextensions/index.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createNextDescribe } from 'e2e-utils'

createNextDescribe(
'app dir css with pageextensions',
'app dir - css with pageextensions',
{
files: __dirname,
skipDeployment: true,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/app-css/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { createNextDescribe } from 'e2e-utils'
import { check } from 'next-test-utils'

createNextDescribe(
'app dir css',
'app dir - css',
{
files: __dirname,
skipDeployment: true,
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/app-middleware/app-middleware.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ createNextDescribe(
)

createNextDescribe(
'app dir middleware without pages dir',
'app dir - middleware without pages dir',
{
files: {
app: new FileRef(path.join(__dirname, 'app')),
Expand Down Expand Up @@ -168,7 +168,7 @@ createNextDescribe(
)

createNextDescribe(
'app dir middleware with middleware in src dir',
'app dir - middleware with middleware in src dir',
{
files: {
'src/app': new FileRef(path.join(__dirname, 'app')),
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/app-prefetch/prefetching.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const browserConfigWithFixedTime = {
}

createNextDescribe(
'app dir prefetching',
'app dir - prefetching',
{
files: __dirname,
skipDeployment: true,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/app-validation/validation.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createNextDescribe } from 'e2e-utils'

createNextDescribe(
'app dir validation',
'app dir - validation',
{
files: __dirname,
skipDeployment: true,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/app/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { BrowserInterface } from 'test/lib/browsers/base'
import { Request } from 'playwright-core'

createNextDescribe(
'app dir',
'app dir basic',
timneutkens marked this conversation as resolved.
Show resolved Hide resolved
{
files: __dirname,
buildCommand: process.env.NEXT_EXPERIMENTAL_COMPILE
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/import/import.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createNextDescribe } from 'e2e-utils'

createNextDescribe(
'app dir imports',
'app dir - imports',
{
files: __dirname,
},
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/next-font/next-font.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const getAttrs = (elems: Cheerio) =>

describe.each([['app'], ['app-old']])('%s', (fixture: string) => {
createNextDescribe(
'app dir next-font',
'app dir - next-font',
{
files: {
app: new FileRef(join(__dirname, fixture)),
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/next-image/next-image-https.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createNextDescribe } from '../../../lib/e2e-utils'

createNextDescribe(
'app dir next-image (with https)',
'app dir - next-image (with https)',
{
files: __dirname,
skipDeployment: true,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/next-image/next-image.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createNextDescribe } from 'e2e-utils'

createNextDescribe(
'app dir next-image',
'app dir - next-image',
{
files: __dirname,
skipDeployment: true,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/skip-trailing-slash-redirect/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ describe('skip-trailing-slash-redirect', () => {
runSharedTests('/')
})

describe('app dir', () => {
describe('app dir - skip trailing slash redirect', () => {
runSharedTests('/with-app-dir/')
})
})
2 changes: 1 addition & 1 deletion test/integration/app-dir-export/test/config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
nextConfig,
} from './utils'

describe('app dir with output export (next dev / next build)', () => {
describe('app dir - with output export (next dev / next build)', () => {
;(process.env.TURBOPACK ? describe.skip : describe)('production mode', () => {
it('should throw when exportPathMap configured', async () => {
nextConfig.replace(
Expand Down
2 changes: 1 addition & 1 deletion test/integration/app-dir-export/test/start.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const exportDir = join(appDir, 'out')
const nextConfig = new File(join(appDir, 'next.config.js'))
let app

describe('app dir with output export (next start)', () => {
describe('app dir - with output export (next start)', () => {
;(process.env.TURBOPACK ? describe.skip : describe)('production mode', () => {
afterEach(async () => {
await killApp(app)
Expand Down
4 changes: 2 additions & 2 deletions test/production/build-spinners/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ describe('build-spinners', () => {
})

it.each([
{ name: 'app dir', files: appDirFiles },
{ name: 'app dir basic', files: appDirFiles },
timneutkens marked this conversation as resolved.
Show resolved Hide resolved
{
name: 'app dir (compile workers)',
name: 'app dir - (compile workers)',
files: [
...appDirFiles,
{
Expand Down
Loading