-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement getOptimizedModuleAliases for Turbopack #56839
Merged
kodiakhq
merged 2 commits into
canary
from
10-14-Implement_getOptimizedModuleAliases_for_Turbopack
Oct 14, 2023
Merged
Implement getOptimizedModuleAliases for Turbopack #56839
kodiakhq
merged 2 commits into
canary
from
10-14-Implement_getOptimizedModuleAliases_for_Turbopack
Oct 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
a team,
ztanner and
feedthejim
as code owners
October 14, 2023 15:30
ijjk
added
Turbopack
Related to Turbopack with Next.js.
created-by: Next.js team
PRs by the Next.js team.
type: next
labels
Oct 14, 2023
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
sokra
approved these changes
Oct 14, 2023
kodiakhq
bot
deleted the
10-14-Implement_getOptimizedModuleAliases_for_Turbopack
branch
October 14, 2023 17:21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Next.js team
PRs by the Next.js team.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures
import url from 'url'
works in the edge runtime when using Turbopack. It also ensures the stubs for fetch / object.assignare applied to the client and edge compilation.