Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lower Node.js version requirement #56943

Merged
merged 10 commits into from
Oct 17, 2023
Merged

chore: lower Node.js version requirement #56943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f2d9d59
chore: lower Node.js version requirement
balazsorban44 Oct 17, 2023
8dd60aa
Update package.json
balazsorban44 Oct 17, 2023
0576a21
Apply suggestions from code review
balazsorban44 Oct 17, 2023
e9f617f
Update package.json
balazsorban44 Oct 17, 2023
e1a8fd1
Merge branch 'canary' into chore/lower-node
kodiakhq[bot] Oct 17, 2023
b44fd99
test with 18.17.0
styfle Oct 17, 2023
cd60416
Merge branch 'canary' into chore/lower-node
ijjk Oct 17, 2023
29a3d77
Merge branch 'canary' into chore/lower-node
huozhi Oct 17, 2023
b01242f
Merge branch 'canary' into chore/lower-node
huozhi Oct 17, 2023
84dca06
Merge branch 'canary' into chore/lower-node
huozhi Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/next-stats-action/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ RUN apt install unzip wget curl nano htop screen build-essential pkg-config libs

RUN ln $(which python3) /usr/bin/python

RUN curl -sfLS https://install-node.vercel.app/v18.18.2 | bash -s -- -f
RUN curl -sfLS https://install-node.vercel.app/v18.17.0 | bash -s -- -f
RUN corepack enable

WORKDIR /next-stats
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/next-stats-action/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"typescript": "5.1.6"
},
"engines": {
"node": ">=18.18.2",
"node": ">=18.17.0",
"pnpm": "8.9.0"
},
"packageManager": "pnpm@8.9.0"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
group: [1, 2, 3, 4, 5]
uses: ./.github/workflows/build_reusable.yml
with:
nodeVersion: 18.18.2
nodeVersion: 18.17.0
skipForDocsOnly: 'yes'
afterBuild: RUST_BACKTRACE=0 NEXT_EXTERNAL_TESTS_FILTERS="$(pwd)/test/turbopack-tests-manifest.json" TURBOPACK=1 node run-tests.js --timings -g ${{ matrix.group }}/5 -c ${TEST_CONCURRENCY} --type integration
secrets: inherit
Expand Down Expand Up @@ -211,7 +211,7 @@ jobs:

uses: ./.github/workflows/build_reusable.yml
with:
nodeVersion: 18.18.2
nodeVersion: 18.17.0
skipForDocsOnly: 'yes'
afterBuild: node run-tests.js --timings -g ${{ matrix.group }}/12 -c ${TEST_CONCURRENCY} --type integration
secrets: inherit
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pr:
variables:
PNPM_CACHE_FOLDER: $(Pipeline.Workspace)/.pnpm-store
NEXT_TELEMETRY_DISABLED: '1'
node_version: ^18.18.2
node_version: ^18.17.0

stages:
- stage: Test
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@
"@types/react-dom": "18.2.13"
},
"engines": {
"node": ">=18.18.2",
"node": ">=18.17.0",
"pnpm": "8.9.0"
},
"packageManager": "pnpm@8.9.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/create-next-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@
"validate-npm-package-name": "3.0.0"
},
"engines": {
"node": ">=18.18.2"
"node": ">=18.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/next/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,6 @@
"zod": "3.22.3"
},
"engines": {
"node": ">=18.18.2"
"node": ">=18.17.0"
}
}
2 changes: 1 addition & 1 deletion test/.stats-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"react-dom": "latest"
},
"engines": {
"node": ">=18.18.2",
"node": ">=18.17.0",
"pnpm": "8.9.0"
},
"packageManager": "pnpm@8.9.0"
Expand Down
Loading