Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): set COREPACK_ENABLE_STRICT: 0 for create-next-app tests #56955

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 17, 2023

I think some of the runners are missing yarn globally installed so its attempting to install with corepack. But the default behavior of corepack is to use the repo version (pnpm in this case) so running yarn will error. This PR disables corepack strict mode to avoid that problem.

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team. labels Oct 17, 2023
@ijjk
Copy link
Member

ijjk commented Oct 17, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js fix-package-manager-test-corepack-strict-off Change
buildDuration 10.3s 10.3s N/A
buildDurationCached 6.1s 6.1s N/A
nodeModulesSize 174 MB 174 MB
nextStartRea..uration (ms) 527ms 532ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-package-manager-test-corepack-strict-off Change
199-HASH.js gzip 27.5 kB 27.5 kB
3f784ff6-HASH.js gzip 53.1 kB 53.1 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 126 kB 126 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-package-manager-test-corepack-strict-off Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-package-manager-test-corepack-strict-off Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-package-manager-test-corepack-strict-off Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-package-manager-test-corepack-strict-off Change
index.html gzip 528 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 525 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix-package-manager-test-corepack-strict-off Change
edge-ssr.js gzip 93.6 kB 93.6 kB N/A
page.js gzip 154 kB 154 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix-package-manager-test-corepack-strict-off Change
middleware-b..fest.js gzip 627 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: c58b098

@styfle styfle marked this pull request as ready for review October 17, 2023 19:36
@ijjk
Copy link
Member

ijjk commented Oct 17, 2023

Failing test suites

Commit: c58b098

pnpm test test/integration/image-optimizer/test/squoosh.test.ts

  • with squoosh > dev support w/o next.config.js > should use cached image file when parameters are the same for animated gif
Expand output

● with squoosh › dev support w/o next.config.js › should use cached image file when parameters are the same for animated gif

expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "4B8iQxM1sYYMqC8mwmI6TrsxJt+oSk+RWGJhir2GKgs=": Object {
-     "0.1697571826766.CXZ99T+7Ygxk6-tOxhVDMs3cEHVNX1+w7hkcDjgeFp8=.gif": "2023-10-17T19:42:46.761Z",
+     "0.1697571826766.CXZ99T+7Ygxk6-tOxhVDMs3cEHVNX1+w7hkcDjgeFp8=.gif": "2023-10-17T19:42:46.765Z",
    },
  }

  1052 |     )
  1053 |     const json2 = await fsToJson(ctx.imagesDir)
> 1054 |     expect(json2).toStrictEqual(json1)
       |                   ^
  1055 |   })
  1056 |
  1057 |   it('should set 304 status without body when etag matches if-none-match', async () => {

  at Object.<anonymous> (integration/image-optimizer/test/util.ts:1054:19)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Oct 17, 2023

Tests Passed

@kodiakhq kodiakhq bot merged commit 6ed4fdd into canary Oct 17, 2023
54 of 59 checks passed
@kodiakhq kodiakhq bot deleted the fix-package-manager-test-corepack-strict-off branch October 17, 2023 19:56
@github-actions github-actions bot added the locked label Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants