-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transforms): enable rsc transforms for the remaining contexts #61231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
Turbopack
Related to Turbopack with Next.js.
created-by: Turbopack team
PRs by the Turbopack team.
type: next
labels
Jan 26, 2024
kwonoj
changed the title
feat(next-core): enable rsc transforms for the remaining contexts
[DONOTMERGE] [WIP] feat(next-core): enable rsc transforms for the remaining contexts
Jan 26, 2024
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
kwonoj
force-pushed
the
rsc-transforms-redux
branch
17 times, most recently
from
January 29, 2024 22:44
d1c95a3
to
c564aae
Compare
kwonoj
force-pushed
the
rsc-transforms-redux
branch
6 times, most recently
from
February 3, 2024 00:28
8897694
to
3a5018b
Compare
kwonoj
force-pushed
the
rsc-transforms-redux
branch
4 times, most recently
from
February 5, 2024 16:58
d9a17e5
to
9f3a533
Compare
kwonoj
force-pushed
the
rsc-transforms-redux
branch
from
February 5, 2024 17:03
9f3a533
to
869ea51
Compare
kwonoj
force-pushed
the
rsc-transforms-redux
branch
from
February 5, 2024 17:30
869ea51
to
c692442
Compare
kwonoj
force-pushed
the
rsc-transforms-redux
branch
from
February 5, 2024 17:32
c692442
to
3441a14
Compare
kwonoj
changed the title
[DONOTMERGE] [WIP] feat(next-core): enable rsc transforms for the remaining contexts
enable rsc transforms for the remaining contexts
Feb 5, 2024
kwonoj
changed the title
enable rsc transforms for the remaining contexts
feat(transforms): enable rsc transforms for the remaining contexts
Feb 5, 2024
kwonoj
commented
Feb 5, 2024
"Error overlay - RSC build errors should throw an error when getServerSideProps is used", | ||
"Error overlay - RSC build errors should throw an error when metadata export is used in client components", | ||
"Error overlay - RSC build errors should throw an error when metadata exports are used together in server components" | ||
], | ||
"failed": [ | ||
"Error overlay - RSC build errors should throw an error when error file is a server component with empty error file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually raises correct error, however turbopack does not trigger hmr if error.js is empty.
kwonoj
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
February 5, 2024 17:50
wbinnssmith
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the Turbopack team.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR wraps up supporting rsc transforms (mostly for the assertion) in Turbopack. PR contains a few changes to support it, including:
This change enables most of the rsc-build* tests and some more other tests. The only failing tests in the rsc-build-errors is due to Turbopack not triggering hmr with empty file.
Closes PACK-2303