Attempt to polyfill globalThis for old chrome #61872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlkeefer
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
ijjk
added a commit
that referenced
this pull request
Jun 18, 2024
Simpler/cleaner alternative to #61872. Attempting to fix bug #58818 (comment) --------- Co-authored-by: JJ Kasper <jj@jjsweb.site>
ijjk
reviewed
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug
#58818 (comment)
Haven't actually tested this - setting up local next.js development is too big of lift at the moment.
Since this code seems to tolerate a
FakeAsyncLocalStorage, perhaps a simpler fix is this one. Feel free to close this PR without comment if the other way is preferable.