Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Revalidate Timings #64370

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Apr 11, 2024

What?

This creates a new SharedRevalidateTimings type that is safe to share amongst different points within the framework for sharing revalidation timings. This is a precursor to #64313 which freezes loaded manifests.

Why?

Using the SharedRevalidateTimings type, we no-longer have to modify the in-memory instance of the prerender manifest to share the revalidation timings for different routes.

Closes NEXT-3083

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Apr 11, 2024
Copy link
Member Author

wyattjoh commented Apr 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wyattjoh and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Apr 11, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
buildDuration 14.1s 14.3s ⚠️ +201ms
buildDurationCached 7.7s 6.5s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +23.8 kB
nextStartRea..uration (ms) 405ms 404ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.1 kB 5.1 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.63 kB 6.63 kB
Client Build Manifests
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 524 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
edge-ssr.js gzip 95.5 kB 95.6 kB N/A
page.js gzip 3.06 kB 3.06 kB
Overall change 3.06 kB 3.06 kB
Middleware size
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
middleware-b..fest.js gzip 624 B 626 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 839 B 839 B
Next Runtimes
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 97.4 kB 97.4 kB
app-page-tur..prod.js gzip 99.2 kB 99.2 kB
app-page-tur..prod.js gzip 93.4 kB 93.4 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.9 kB 91.9 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.3 kB 51.3 kB N/A
Overall change 897 kB 897 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js wyattjohnson/shared-revalidate-timings Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 106 kB 107 kB ⚠️ +390 B
Overall change 106 kB 107 kB ⚠️ +390 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 64a1632

@wyattjoh wyattjoh marked this pull request as ready for review April 11, 2024 23:31
@wyattjoh wyattjoh force-pushed the wyattjohnson/shared-revalidate-timings branch from d5ad643 to 64a1632 Compare April 11, 2024 23:32
@wyattjoh wyattjoh enabled auto-merge (squash) April 11, 2024 23:43
@wyattjoh wyattjoh disabled auto-merge April 11, 2024 23:55
@wyattjoh wyattjoh merged commit 6bc9f79 into canary Apr 11, 2024
80 checks passed
@wyattjoh wyattjoh deleted the wyattjohnson/shared-revalidate-timings branch April 11, 2024 23:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants