backport: server actions #69612
Merged
backport: server actions #69612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lubieowoce
commented
Sep 3, 2024
•
lubieowoce
commented
- optimize server actions #66523 (avoid conflicts in #69183 + a useful improvement on its own)
- refactor: create shared utils for mod resource #69145
- Apply optimization for unused actions #69178
- Improve SWC transform ID generation #69183
lubieowoce
force-pushed
the
backport-14-3-0/server-actions
branch
2 times, most recently
from
a9549af
to
7bd0cdc
Compare
### What? optimize allocations in server actions transform In one edge case it reduces allocations from 30GB to 4.5MB and time from 760ms to 11ms. ### Why? make it faster
This adds an extra `hash_salt` option to the Server Actions transform's `generate_action_id` method which defaults to empty for now (so no actual behavior changes). When set, the salt will be used to prefix the payload.
lubieowoce
force-pushed
the
backport-14-3-0/server-actions
branch
from
7bd0cdc
to
6473113
Compare
huozhi
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.