Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move syntax formatting to prettier #7454

Merged
merged 7 commits into from
May 29, 2019
Merged

Move syntax formatting to prettier #7454

merged 7 commits into from
May 29, 2019

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented May 29, 2019 •
edited
Loading

Unifies the codebase to a single formatting.

Runs prettier over:

  • examples (was already the case)
  • packages (Next.js core, specifically all .js and .ts files)
  • **/*.ts
  • **/*.md
  • packages/**/*.json

Removes tslint in favor of standard which we already had running. Potentially might want to remove standard in the future, but not a priority right now.

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/prettier Change
Build Duration 15.6s 15.2s -473ms
node_modules Size 41 MB 41 MB -3.92 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.92 kB 2.92 kB ✓
Client _app gzip Size 1.2 kB 1.2 kB ✓
Client _error Size 8.25 kB 8.25 kB ✓
Client _error gzip Size 3.13 kB 3.13 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.74 kB 7.74 kB ✓
Client commons Size 184 kB 184 kB ✓
Client commons gzip Size 59.8 kB 59.8 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 813 kB 813 kB ⚠️ +42 B
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/prettier Change
Build Duration 16.2s 16.7s ⚠️ +541ms
node_modules Size 41 MB 41 MB -3.92 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.92 kB 2.92 kB ✓
Client _app gzip Size 1.2 kB 1.2 kB ✓
Client _error Size 8.25 kB 8.25 kB ✓
Client _error gzip Size 3.13 kB 3.13 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.74 kB 7.74 kB ✓
Client commons Size 184 kB 184 kB ✓
Client commons gzip Size 59.8 kB 59.8 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 354 kB 354 kB ⚠️ +7 B
Serverless pages/link gzip Size 91.6 kB 91.7 kB ⚠️ +8 B
Serverless pages/index Size 345 kB 345 kB ⚠️ +7 B
Serverless pages/index gzip Size 89.3 kB 89.3 kB ⚠️ +6 B
Serverless pages/_error Size 344 kB 344 kB ⚠️ +7 B
Serverless pages/_error gzip Size 89 kB 89.1 kB ⚠️ +7 B
Serverless pages/routerDirect Size 345 kB 345 kB ⚠️ +7 B
Serverless pages/routerDirect gzip Size 89.2 kB 89.2 kB ⚠️ +6 B
Serverless pages/withRouter Size 345 kB 345 kB ⚠️ +7 B
Serverless pages/withRouter gzip Size 89.2 kB 89.2 kB ⚠️ +8 B
Build Dir Size 2.44 MB 2.44 MB ⚠️ +85 B

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/prettier Change
Build Duration 14.8s 14.8s -20ms
node_modules Size 41 MB 41 MB -4 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.92 kB 2.92 kB ✓
Client _app gzip Size 1.2 kB 1.2 kB ✓
Client _error Size 8.25 kB 8.25 kB ✓
Client _error gzip Size 3.13 kB 3.13 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.74 kB 7.74 kB ✓
Client commons Size 184 kB 184 kB ✓
Client commons gzip Size 59.8 kB 59.8 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 813 kB 813 kB ⚠️ +42 B
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/prettier Change
Build Duration 17.3s 16s -1.3s
node_modules Size 41 MB 41 MB -4 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.92 kB 2.92 kB ✓
Client _app gzip Size 1.2 kB 1.2 kB ✓
Client _error Size 8.25 kB 8.25 kB ✓
Client _error gzip Size 3.13 kB 3.13 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.74 kB 7.74 kB ✓
Client commons Size 184 kB 184 kB ✓
Client commons gzip Size 59.8 kB 59.8 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 354 kB 354 kB ⚠️ +7 B
Serverless pages/link gzip Size 91.6 kB 91.7 kB ⚠️ +7 B
Serverless pages/index Size 345 kB 345 kB ⚠️ +7 B
Serverless pages/index gzip Size 89.3 kB 89.3 kB ⚠️ +7 B
Serverless pages/_error Size 344 kB 344 kB ⚠️ +7 B
Serverless pages/_error gzip Size 89 kB 89.1 kB ⚠️ +7 B
Serverless pages/routerDirect Size 345 kB 345 kB ⚠️ +7 B
Serverless pages/routerDirect gzip Size 89.2 kB 89.2 kB ⚠️ +7 B
Serverless pages/withRouter Size 345 kB 345 kB ⚠️ +7 B
Serverless pages/withRouter gzip Size 89.2 kB 89.2 kB ⚠️ +7 B
Build Dir Size 2.44 MB 2.44 MB ⚠️ +85 B

@timneutkens timneutkens changed the title [WIP] Move syntax formatting to prettier Move syntax formatting to prettier May 29, 2019
@timneutkens timneutkens merged commit 3e51ddb into vercel:canary May 29, 2019
@timneutkens timneutkens deleted the add/prettier branch May 29, 2019 11:57
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dav-is dav-is Awaiting requested review from dav-is

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timneutkens