-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional items to shared cache #237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 80.30% 81.25% +0.94%
==========================================
Files 13 13
Lines 1447 1472 +25
Branches 539 545 +6
==========================================
+ Hits 1162 1196 +34
+ Misses 113 109 -4
+ Partials 172 167 -5
Continue to review full report at Codecov.
|
guybedford
approved these changes
Oct 2, 2021
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 14, 2021
This updates to the latest version of `@vercel/nft` which includes better shared caching between runs. x-ref: vercel/nft#239 x-ref: vercel/nft#238 x-ref: vercel/nft#237
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
This updates to the latest version of `@vercel/nft` which includes better shared caching between runs. x-ref: vercel/nft#239 x-ref: vercel/nft#238 x-ref: vercel/nft#237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we leverage the shared cache when preforming expensive checks to provide better performance when tracing multiple files individually but sharing the same cache instead of tracing them in the same
nodeFileTrace
run.In one test repo this brought tracing down from 130 seconds -> 25 seconds while tracing separately. which brings this much closer with the time it took when tracing all files in one
nodeFileTrace
run which was around 17 seconds.