add next.config.js validation to turbopack #3105

ForsakenHarmony · 2022-12-21T03:20:29Z

No description provided.

vercel · 2022-12-21T03:20:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-cra-web	🔄 Building (Inspect)			Jan 10, 2023 at 3:58PM (UTC)
examples-native-web	🔄 Building (Inspect)			Jan 10, 2023 at 3:58PM (UTC)
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 10, 2023 at 3:58PM (UTC)
turbo-vite-web	🔄 Building (Inspect)			Jan 10, 2023 at 3:58PM (UTC)

6 Ignored Deployments

Name	Status	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Jan 10, 2023 at 3:58PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Jan 10, 2023 at 3:58PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Jan 10, 2023 at 3:58PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Jan 10, 2023 at 3:58PM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)	Jan 10, 2023 at 3:58PM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)	Jan 10, 2023 at 3:58PM (UTC)

ForsakenHarmony · 2022-12-21T03:20:41Z

Current dependencies on/for this PR:

main
- PR add next.config.js validation to turbopack #3105 👈
  - PR read env vars from next.config.js #3128

This comment was auto-generated by Graphite.

github-actions · 2022-12-21T03:25:29Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Rust lints
Rust tests
Rust benchmark tests

See workflow summary for details

jridgewell · 2022-12-22T03:29:10Z

crates/next-core/js/src/entry/config/next.js

-  nextConfig.rewrites = await nextConfig.rewrites?.();
+
+  nextConfig.generateBuildId = await nextConfig.generateBuildId?.();
+  nextConfig.headers = await nextConfig.headers?.();


the loadCustomRoutes from next/dist/lib/load-custom-routes will perform some validation and loading for headers/redirects/rewrites.

I'm not entirely sure what you're telling me here, is that a function I should use?

jridgewell · 2022-12-22T03:31:10Z

crates/next-core/src/next_config.rs

+#[derive(Clone, Debug, PartialEq, Serialize, Deserialize, TraceRawVcs)]
+#[serde(rename_all = "camelCase")]
+struct OnDemandEntriesConfig {
+    max_inactive_age: f64,


Are these floats or u64s?

I guess JS can always provide Infinity there, hence we treat any number as a f64.

yeah, ideally these would be u64, but for JS compat I've put them in here as f64 for now

jridgewell · 2022-12-22T03:36:42Z

I admittedly didn't fully review every line.

alexkirsz · 2022-12-22T10:44:20Z

I'm also validating next.config.js in #3071 (basePath specifically) so that will likely cause a conflict.

alexkirsz · 2022-12-22T10:46:11Z

crates/next-core/Cargo.toml

@@ -11,9 +11,11 @@ bench = false
 [dependencies]
 anyhow = "1.0.47"
 auto-hash-map = { path = "../auto-hash-map" }
+crossterm = "0.25"


Put this dependency at the workspace level? We now use it for both turbopack-cli-utils and this.

I think there are a lot of dependencies that are used across multiple crates but are not at the workspace level, anyhow above is a good example

Should we move all of those to the workspace?

Yes. I created WEB-174 a while back to tackle this.

crates/next-core/src/next_config.rs

alexkirsz · 2022-12-22T10:51:59Z

crates/next-core/src/next_config.rs

+            // default to 50MB limit
+            isr_memory_cache_size: Some(50.0 * 1024.0 * 1024.0),
+            // default to 128KB
+            large_page_data_bytes: Some(128.0 * 1000.0),


Suggested change

large_page_data_bytes: Some(128.0 * 1000.0),

large_page_data_bytes: Some(128.0 * 1024.0),

Unless it was also defined this way in JS land?

It was, yes
https://github.com/vercel/next.js/blob/canary/packages/next/src/server/config-shared.ts#L607

alexkirsz · 2022-12-22T10:53:35Z

crates/next-core/src/next_config.rs

+#[derive(Clone, Debug, PartialEq, Serialize, Deserialize, TraceRawVcs)]
+#[serde(rename_all = "camelCase")]
+struct OnDemandEntriesConfig {
+    max_inactive_age: f64,


I guess JS can always provide Infinity there, hence we treat any number as a f64.

alexkirsz · 2022-12-22T10:54:21Z

crates/next-core/src/next_config.rs

+    "experimental.serverComponentsExternalPackages",
+];
+
+pub async fn validate_next_config(


Does this need to be pub?

Suggested change

pub async fn validate_next_config(

async fn validate_next_config(

alexkirsz · 2022-12-22T10:55:05Z

crates/next-core/src/next_config.rs

    pub images: ImageConfig,
+
+    #[serde(flatten)]


That's a cool use of flatten.

ForsakenHarmony · 2023-01-16T19:45:47Z

closing for now

github-actions bot added the area: turbopack label Dec 21, 2022

vercel bot deployed to Preview – turbo-site December 21, 2022 03:21 View deployment

ForsakenHarmony force-pushed the hrmny/web-352-nextconfigjs-validation branch from 03e89eb to ede02a5 Compare December 22, 2022 01:07

vercel bot deployed to Preview – turbo-site December 22, 2022 01:08 View deployment

ForsakenHarmony force-pushed the hrmny/web-352-nextconfigjs-validation branch from ede02a5 to e126a23 Compare December 22, 2022 03:15

vercel bot deployed to Preview – turbo-site December 22, 2022 03:16 View deployment

ForsakenHarmony marked this pull request as ready for review December 22, 2022 03:16

ForsakenHarmony requested a review from a team as a code owner December 22, 2022 03:16

ForsakenHarmony force-pushed the hrmny/web-352-nextconfigjs-validation branch from e126a23 to 586f141 Compare December 22, 2022 03:19

vercel bot deployed to Preview – turbo-site December 22, 2022 03:20 View deployment

jridgewell approved these changes Dec 22, 2022

View reviewed changes

alexkirsz approved these changes Dec 22, 2022

View reviewed changes

ForsakenHarmony mentioned this pull request Dec 22, 2022

read env vars from next.config.js #3128

Merged

ForsakenHarmony force-pushed the hrmny/web-352-nextconfigjs-validation branch from 586f141 to c72eea5 Compare January 3, 2023 13:52

vercel bot deployed to Preview – turbo-site January 3, 2023 13:52 View deployment

ForsakenHarmony force-pushed the hrmny/web-352-nextconfigjs-validation branch from c72eea5 to 66720b7 Compare January 5, 2023 16:18

vercel bot deployed to Preview – turbo-site January 5, 2023 16:19 View deployment

ForsakenHarmony added 3 commits January 10, 2023 16:51

add next.config.js validation to turbopack

aa1f0d7

fixes

ef559a4

move crossterm dependency to root

842604d

ForsakenHarmony force-pushed the hrmny/web-352-nextconfigjs-validation branch from d77177d to 842604d Compare January 10, 2023 15:57

ForsakenHarmony requested a review from a team as a code owner January 10, 2023 15:57

ForsakenHarmony requested review from nathanhammond and chris-olszewski January 10, 2023 15:57

vercel bot deployed to Preview – turbo-site January 10, 2023 15:58 View deployment

ForsakenHarmony closed this Jan 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add next.config.js validation to turbopack #3105

add next.config.js validation to turbopack #3105

ForsakenHarmony commented Dec 21, 2022

vercel bot commented Dec 21, 2022 •

edited

Loading

ForsakenHarmony commented Dec 21, 2022 •

edited

Loading

github-actions bot commented Dec 21, 2022 •

edited

Loading

jridgewell Dec 22, 2022

ForsakenHarmony Jan 5, 2023

jridgewell Dec 22, 2022

alexkirsz Dec 22, 2022

ForsakenHarmony Jan 5, 2023

jridgewell commented Dec 22, 2022

alexkirsz commented Dec 22, 2022 •

edited

Loading

alexkirsz Dec 22, 2022

ForsakenHarmony Jan 5, 2023

alexkirsz Jan 5, 2023

alexkirsz Dec 22, 2022

ForsakenHarmony Jan 5, 2023

alexkirsz Dec 22, 2022

alexkirsz Dec 22, 2022

ForsakenHarmony Jan 5, 2023

alexkirsz Dec 22, 2022

ForsakenHarmony commented Jan 16, 2023

	large_page_data_bytes: Some(128.0 * 1000.0),
	large_page_data_bytes: Some(128.0 * 1024.0),

	pub async fn validate_next_config(
	async fn validate_next_config(

add next.config.js validation to turbopack #3105

add next.config.js validation to turbopack #3105

Conversation

ForsakenHarmony commented Dec 21, 2022

vercel bot commented Dec 21, 2022 • edited Loading

ForsakenHarmony commented Dec 21, 2022 • edited Loading

github-actions bot commented Dec 21, 2022 • edited Loading

⚠️ CI failed ⚠️

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jridgewell commented Dec 22, 2022

alexkirsz commented Dec 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ForsakenHarmony commented Jan 16, 2023

vercel bot commented Dec 21, 2022 •

edited

Loading

ForsakenHarmony commented Dec 21, 2022 •

edited

Loading

github-actions bot commented Dec 21, 2022 •

edited

Loading

alexkirsz commented Dec 22, 2022 •

edited

Loading