Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): ignore node_modules in docker #3301

Merged
merged 2 commits into from
Jan 13, 2023
Merged

fix(examples): ignore node_modules in docker #3301

merged 2 commits into from
Jan 13, 2023

Conversation

tknickman
Copy link
Member

Fixes #3257

@tknickman tknickman requested a review from a team as a code owner January 13, 2023 00:10
@vercel
Copy link

vercel bot commented Jan 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-nonmonorepo 🔄 Building (Inspect) Jan 13, 2023 at 0:49AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 0:49AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 0:49AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 13, 2023 at 0:49AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 13, 2023 at 0:49AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 0:49AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 0:49AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 0:49AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2023 at 0:49AM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 0:49AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@tknickman tknickman mentioned this pull request Jan 13, 2023
Closed
nathanhammond
nathanhammond approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, but also I suspect that we should maybe change which side we do the prune on.

@tknickman tknickman merged commit 96cc535 into main Jan 13, 2023
@tknickman tknickman deleted the tomknickman/turbo-682-yarn-global-install-in-docker-appears branch January 13, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanhammond nathanhammond nathanhammond approved these changes

@mehulkar mehulkar Awaiting requested review from mehulkar mehulkar is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[turborepo] Cannot find module 'turbo' when using docker to build
2 participants
@tknickman @nathanhammond