Disable mdx parsing in turbotrace #3304
Merged
+233
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Benchmark for 012bd95Click to view benchmark
|
⏳ CI is running again... ⏳ |
sokra
requested changes
Jan 13, 2023
crates/turbopack/tests/node-file-trace/integration/mdx/index.js
Outdated
Show resolved
Hide resolved
Benchmark for 83bf78cClick to view benchmark
|
|
Why do we not want to parse in turbotrace? Don't we still want to resolve the imports of the mdx files? |
Brooooooklyn
force-pushed
the
disable-mdx-in-turbotrace
branch
from
34c6e30
to
46d21ec
Compare
Align the behavior with https://github.com/vercel/nft. Turbotrace is running in two phases in next.js projects:
Tracing the webpack entries is because we need to trace static assets like CSS/images that could not be traced in output. So, ignoring MDX is totally safe in this step. |
|
@Brooooooklyn what happens when you import css or an image from mdx? |
|
You could use https://mdxjs.com/packages/node-loader/ from node to import mdx. In which case we also need to trace dependencies in mdx, so mdx need to be parsed. |
In this case, they can use |
Benchmark for 1c04f5d
Click to view full benchmark
|
Brooooooklyn
force-pushed
the
disable-mdx-in-turbotrace
branch
from
46d21ec
to
1659f9b
Compare
|
@sokra added the |
Benchmark for 115fdf8Click to view benchmark
|
Brooooooklyn
added
the
pr: automerge
Benchmark for 8b4f754Click to view benchmark
|
Benchmark for 72d4294
Click to view full benchmark
|
sokra
approved these changes
Jan 17, 2023
Benchmark for 6e3bc66Click to view benchmark
|
Benchmark for 4e8e53b
Click to view full benchmark
|
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Jan 18, 2023
It's not necessary to enable `MDX` parsing in turbotrace, and there was a parsing error that caused the build to fail when I was trying to enable turbotrace in `verce/site`: https://vercel.com/vercel/vercel-site/7pFWUVMWVAv3jC44WD2nBnwrbJpM Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
It's not necessary to enable `MDX` parsing in turbotrace, and there was a parsing error that caused the build to fail when I was trying to enable turbotrace in `verce/site`: https://vercel.com/vercel/vercel-site/7pFWUVMWVAv3jC44WD2nBnwrbJpM Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
It's not necessary to enable `MDX` parsing in turbotrace, and there was a parsing error that caused the build to fail when I was trying to enable turbotrace in `verce/site`: https://vercel.com/vercel/vercel-site/7pFWUVMWVAv3jC44WD2nBnwrbJpM Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
It's not necessary to enable `MDX` parsing in turbotrace, and there was a parsing error that caused the build to fail when I was trying to enable turbotrace in `verce/site`: https://vercel.com/vercel/vercel-site/7pFWUVMWVAv3jC44WD2nBnwrbJpM Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary to enable
MDXparsing in turbotrace, and there was a parsing error that caused the build to fail when I was trying to enable turbotrace inverce/site: https://vercel.com/vercel/vercel-site/7pFWUVMWVAv3jC44WD2nBnwrbJpM