-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error overlay sometimes now showing #3331
fix error overlay sometimes now showing #3331
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
@@ -116,6 +116,15 @@ function aggregateUpdates( | |||
const key = resourceKey(msg.resource); | |||
const aggregated = chunksWithUpdates.get(key); | |||
|
|||
if (msg.type === "issues" && aggregated == null && hasIssues) { | |||
// add an empty record to make sure we don't call `onBuildOk` | |||
chunksWithUpdates.set(key, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We check if there are entries in the map below, so even if we have no updates we insert an empty record to make sure it doesn't think everything is fine
617c184
to
f95e796
Compare
Benchmark for b9943daClick to view benchmark
|
🟢 CI successful 🟢Thanks |
@@ -116,6 +116,15 @@ function aggregateUpdates( | |||
const key = resourceKey(msg.resource); | |||
const aggregated = chunksWithUpdates.get(key); | |||
|
|||
if (msg.type === "issues" && aggregated == null && hasIssues) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Looks like this can be merged with the if statements below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be, but imo makes it harder to read
Any chance this fixes WEB-439? |
@wbinnssmith it might |
No description provided.