Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify (questionable?) VcTransparentRead by merging T and Repr #8810

Closed
wants to merge 1 commit into from

Conversation

bgw
Copy link
Member

@bgw bgw commented Jul 22, 2024

Update: Closed. I plan to take a different approach: #8843 (comment)

The plan is to drop collection generics, which will also remove the need for the Repr type.

This was only used by generics.
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:48pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:48pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:48pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:48pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 6:48pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 6:48pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 6:48pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 6:48pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 6:48pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 6:48pm

Copy link
Member Author

bgw commented Jul 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bgw and the rest of your teammates on Graphite Graphite

@bgw bgw changed the title Simplify VcTransparentRead by merging T and Repr Simplify (questionable?) VcTransparentRead by merging T and Repr Jul 22, 2024
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs

crates/next-core/src/next_telemetry.rs:42:9: �[38;5;9merror[E0271]: type mismatch resolving `<DiagnosticPayload as VcValueType>::Read == VcTransparentRead<DiagnosticPayload, HashMap<RcStr, _>, _>`
crates/next-core/src/next_telemetry.rs:82:9: �[38;5;9merror[E0271]: type mismatch resolving `<DiagnosticPayload as VcValueType>::Read == VcTransparentRead<DiagnosticPayload, HashMap<RcStr, _>, _>`
error: could not compile `next-core` (lib) due to 2 previous errors

See job summary for details

Copy link
Contributor

github-actions bot commented Jul 22, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Member Author

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing PR, as I plan to take a different approach: #8843 (comment)

The plan is to drop collection generics, which will also remove the need for the Repr type.

@bgw bgw closed this Jul 30, 2024
@bgw bgw deleted the bgw/vc-read-repr branch August 4, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant