feat(query): adding indirect and all dependencies for tasks #9207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NicholasLYang and the rest of your teammates on |
NicholasLYang
changed the title
NicholasLYang
force-pushed
the
nicholasyang/add-indirect-task-dependencies
branch
from
c0e5833
to
c1242c8
Compare
NicholasLYang
force-pushed
the
nicholasyang/add-task-dependencies
branch
from
adb85f8
to
ea55c51
Compare
NicholasLYang
force-pushed
the
nicholasyang/add-indirect-task-dependencies
branch
from
c1242c8
to
60d2f51
Compare
chris-olszewski
approved these changes
Oct 8, 2024
Comment on lines
24
to
39
| pub fn transitive_closure< | ||
| 'a, | ||
| 'b, | ||
| N: Hash + Eq + PartialEq + Clone + 'b, | ||
| M: TryFrom<N> + Hash + Eq + PartialEq, | ||
| I: IntoIterator<Item = &'b N>, | ||
| >( | ||
| graph: &'a Graph<N, ()>, | ||
| node_lookup: &'a HashMap<M, petgraph::graph::NodeIndex>, | ||
| nodes: I, | ||
| direction: petgraph::Direction, | ||
| ) -> HashSet<&'a N> { | ||
| let indices = nodes | ||
| .into_iter() | ||
| .filter_map(|node| node_lookup.get(&node.to_owned().try_into().ok()?)) | ||
| .copied(); |
There was a problem hiding this comment.
I think having callers resolve the nodes to indices themselves makes this a lot more legible and easier to call in a lot of cases
Suggested change
| pub fn transitive_closure< | |
| 'a, | |
| 'b, | |
| N: Hash + Eq + PartialEq + Clone + 'b, | |
| M: TryFrom<N> + Hash + Eq + PartialEq, | |
| I: IntoIterator<Item = &'b N>, | |
| >( | |
| graph: &'a Graph<N, ()>, | |
| node_lookup: &'a HashMap<M, petgraph::graph::NodeIndex>, | |
| nodes: I, | |
| direction: petgraph::Direction, | |
| ) -> HashSet<&'a N> { | |
| let indices = nodes | |
| .into_iter() | |
| .filter_map(|node| node_lookup.get(&node.to_owned().try_into().ok()?)) | |
| .copied(); | |
| pub fn transitive_closure< | |
| N: Hash + Eq + PartialEq, | |
| I: IntoIterator<Item = NodeIndex>, | |
| >( | |
| graph: &Graph<N, ()>, | |
| indicies: I, | |
| direction: petgraph::Direction, | |
| ) -> HashSet<&N> { |
A majority of the calls go from something like
let mut dependencies = turborepo_graph_utils::transitive_closure(
self.transitive_closure_inner(Some(node), petgraph::Direction::Outgoing);
&self.graph,
&self.node_lookup,
Some(node),
petgraph::Direction::Outgoing,
);
to
let mut dependencies = turborepo_graph_utils::transitive_closure(
self.transitive_closure_inner(Some(node), petgraph::Direction::Outgoing);
&self.graph,
self.node_lookup.get(node).copied(),
petgraph::Direction::Outgoing,
);
NicholasLYang
force-pushed
the
nicholasyang/add-indirect-task-dependencies
branch
from
60d2f51
to
dcf4ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds indirect and all dependencies as fields on tasks.
You can review commit by commit.
Testing Instructions
Adds tests along with a new fixture based off of
task-dependencies/complex