Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): enable corepack for npm in integration tests #9233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(ci): enable corepack for npm in integration tests #9233

wants to merge 2 commits into from
+6 −1

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Oct 8, 2024

No description provided.

@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Oct 8, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 3:27pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 3:27pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 3:27pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 3:27pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 3:27pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 3:27pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 3:27pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 3:27pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 3:27pm

@styfle styfle changed the title chore(ci): enable coreppack for npm in integration tests chore(ci): enable corepack for npm in integration tests Oct 8, 2024
styfle
styfle reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@styfle styfle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo.

Alternatively you could do without checking the value of $pkgManager

corepack enable $pkgManager

@mehulkar mehulkar marked this pull request as ready for review October 8, 2024 17:53
@mehulkar mehulkar requested a review from a team as a code owner October 8, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehulkar @styfle @NicholasLYang