Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn on empty cache #9236

Merged
merged 4 commits into from
Oct 10, 2024
Merged

feat: warn on empty cache #9236

merged 4 commits into from
Oct 10, 2024

Conversation

NicholasLYang
Copy link
Contributor

Description

Warns if cache payload consists of just the log file and output globs are specified.

Testing Instructions

Turns out all of our test fixtures have empty outputs so we get a lot of these warnings in tests

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 2:34pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:34pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:34pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:34pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:34pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:34pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:34pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:34pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:34pm

Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

I think we should also skip the cache save in this case. But we can also address that in a follow up.

@tknickman tknickman merged commit dc705a2 into main Oct 10, 2024
40 checks passed
@tknickman tknickman deleted the nicholasyang/warn-on-empty-cache branch October 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants