[next] Support Edge API Endpoints #7905
Conversation
…n-test' into support-edge-api-endpoints
| for (const edgeFunctionFile of Object.keys( | ||
| middlewareManifest?.functions ?? {} | ||
| )) { | ||
| delete pages[edgeFunctionFile.slice(1) + '.js']; |
There was a problem hiding this comment.
Are we planning to add an error when runtime: 'edge' is used with a getStaticProps page? Currently it isn't compatible with the Prerender type as it expects the lambda output so will break for that case.
There was a problem hiding this comment.
That's a good question, but right now with vercel/next.js#37481 it's only going to be api endpoints and not pages, so Prerender is not expected to be emitted for this output.
cc @shuding that mentioned some work related to pages 👀
There was a problem hiding this comment.
Might be good to add an invariant here to ensure we only delete API pages for now to be safe then
There was a problem hiding this comment.
Although we don't have FS in the edge runtime, we still allow getStaticProps together with runtime: 'edge'. It's just that it currently behaves like SSR.
There was a problem hiding this comment.
Soon we will have to remove this constraint as we're refactoring the edge SSR implementation to use functions here :)
Schniz
force-pushed
the
support-edge-api-endpoints
branch
from
b9578b1
to
22a0262
Compare
|
@ijjk can you re-review? |
Related Issues
📋 Checklist
Tests
yarn test-unitCode Review