Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jts/1989 invite suggestions #72

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

JohnSimonsen
Copy link

Ensure suggestions in InviteDialog to only show members of the current space

This PR adds another layer of filtering of the "Recents" and "Sugested" lists

  • Creates a list of userIds of the currently selected space
  • Uses the list to filter what is added or returned in buildRecents and buildSuggestions

Originally I think the plan was to clear the store on context switch (switching spaces)
But as the InviteDialog builds the lists on render, and by creating a list of possible suggestions using members of all rooms available. I that could be more dificult. So instead i modified the buildRecents and buildSuggestions methods slightly.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

John Tore Simonsen added 2 commits August 14, 2024 17:04
@JohnSimonsen JohnSimonsen added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 15, 2024
@JohnSimonsen JohnSimonsen merged commit 105311a into verji-develop Aug 20, 2024
11 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant