Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures that the module is not 'forced' to be esm #610

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

erikyo
Copy link
Collaborator

@erikyo erikyo commented Mar 29, 2024

in order not to break compatibility like the bundlers who used this module as in the case of TWBS (see #609) in this pr we ensure that the module remains 'agnostic' as it has always been

HOW?

  • Removes the type: "module"
  • Renames the rollup config file as .mjs

SideNotes:

  • @verlok ask me to remove the AMD module since nowdays isn't anymore useful

close #609

@verlok verlok merged commit 0c5e575 into verlok:master Mar 29, 2024
@erikyo erikyo deleted the exports/module-defaults branch March 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v19.0.0 build error with Hugo
2 participants