Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ways to add dash plugins and to configure dash playback. #51

Closed
wants to merge 3 commits into from

Conversation

nweber
Copy link

@nweber nweber commented Mar 5, 2016

Added information about additions to the README file.

@gkatsev
Copy link
Member

gkatsev commented Mar 5, 2016

Hi @nweber, thanks for the PR. We're trying to come up with a better way of passing options to source handlers. See videojs/video.js#2616
We probably won't pull this in until we resolve that (which, I think we're finally close to a consensus on what to do for it.

@forbesjo
Copy link
Contributor

forbesjo commented Mar 7, 2016

@gkatsev this change looks to be against the 1.x-dash.js-2.0.0 branch which is open against 1.x. 1.x is compatible with video.js 4.0 so it won't have access to any source handler enhancements.

@gkatsev
Copy link
Member

gkatsev commented Mar 7, 2016

Ah, missed that.

@gkatsev
Copy link
Member

gkatsev commented Mar 7, 2016

Is it still a tech then?

@gkatsev
Copy link
Member

gkatsev commented Mar 7, 2016

I guess it was still a source handler, I guess I forgot how early we got source handlers in videojs.

@gkatsev
Copy link
Member

gkatsev commented Mar 7, 2016

Also, the decisions we make for videojs/video.js#2616 may still be applicable to the older dash plugin.

@nweber
Copy link
Author

nweber commented Mar 7, 2016

Makes sense. I'm going to close this one for now. I've submitted a different pull request to enable a particular feature.

@nweber nweber closed this Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants