-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hook before dash.js media player initialization #77
Conversation
@@ -48,6 +51,10 @@ var dashjs = require('dashjs'); | |||
Html5DashJS.useVideoJSDebug(this.mediaPlayer_); | |||
} | |||
|
|||
if (Html5DashJS.beforeInitialize) { | |||
Html5DashJS.beforeInitialize(player, this.mediaPlayer_); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can beforeInitialize()
replace useVideoJSDebug()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging through videojs.log could then be used as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely, and good call. Will update.
|
||
```javascript | ||
videojs.Html5DashJS.beforeInitialize = function(player, mediaPlayer) { | ||
// Log MedaPlayer messages through video.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Meda/Media
Missing some test changes from https://github.com/videojs/videojs-contrib-dash/pull/75/files#diff-a7f35573a9a8c8e9ca9b2f511f994675R57 |
No description provided.