don't throw InvalidArrayOffset when dealing with templates (#5019)

vimeo · Jan 14, 2021 · 7a40443 · 7a40443
1 parent 26f756d
commit 7a40443
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/ArrayAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/ArrayAnalyzer.php
@@ -154,6 +154,7 @@ public static function analyze(
                     && !$atomic_key_type instanceof Type\Atomic\TInt
                     && !$atomic_key_type instanceof Type\Atomic\TArrayKey
                     && !$atomic_key_type instanceof Type\Atomic\TMixed
+                    && !$atomic_key_type instanceof Type\Atomic\TTemplateParam
                     && !(
                         $atomic_key_type instanceof Type\Atomic\TObjectWithProperties
                         && isset($atomic_key_type->methods['__toString'])

diff --git a/tests/ArrayAssignmentTest.php b/tests/ArrayAssignmentTest.php
@@ -1506,6 +1506,16 @@ function getList(array $list): array {
                         return $list;
                     }'
             ],
+            'ArrayCreateTemplateArrayKey' => [
+                '/**
+                  * @template K of array-key
+                  * @param K $key
+                  */
+                function with($key): void
+                {
+                    [$key => 123];
+                }',
+            ],
         ];
     }