Does not detect that switch case could be hit inside loop

[ciaranmcnulty]

Something wrong here with the flow analysis

https://psalm.dev/r/eef81dd77c

Removing the redundant conditional also removes the TypeDoesNotContainType

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/eef81dd77c

<?php

function analyse(array $tokens): int
{
    $state = 1;

    foreach ($tokens as $_) {
        switch ($state) {
            case 3:
                break;
            case 2:
                if (true) {
                    $state = 3;
                }
                break;
            default:
                $state = 2;
        }
    }
    
    return $state;
}

Psalm output (using commit 1afce4d):

ERROR: TypeDoesNotContainType - 9:18 - int(3) cannot be identical to int(1)|int(2)

ERROR: RedundantCondition - 12:21 - if (true) is redundant

[muglug]

Reduced slightly to

<?php

function analyse(): int {
    $state = 1;

    while (rand(0, 1)) {
        switch ($state) {
            case 3:
                break;
            case 2:
                if (rand(0, 1)) {
                    $state = 3;
                }
                break;
            default:
                $state = 2;
        }
    }
    
    return $state;
}