Revert "Do not consider isset checks on static properties as redundant"

src/Psalm/Internal/Analyzer/ClassAnalyzer.php

@@ -802,15 +802,13 @@ public static function addContextProperties(
                 ) {
                     $property_type->initialized = false;
                     $property_type->from_property = true;
-                    $property_type->from_static_property = $property_storage->is_static === true;
                 }
             } else {
                 $property_type = Type::getMixed();
 
                 if (!$property_storage->has_default && !$property_storage->is_promoted) {
                     $property_type->initialized = false;
                     $property_type->from_property = true;
-                    $property_type->from_static_property = $property_storage->is_static === true;
                 }
             }
 

src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php

@@ -255,7 +255,6 @@ public static function analyze(
             if ($assign_value_type) {
                 $assign_value_type = clone $assign_value_type;
                 $assign_value_type->from_property = false;
-                $assign_value_type->from_static_property = false;
                 $assign_value_type->ignore_isset = false;
             } else {
                 $assign_value_type = Type::getMixed();

src/Psalm/Internal/Type/NegatedAssertionReconciler.php

@@ -82,7 +82,6 @@ public static function reconcile(
                     && $key
                     && strpos($key, '[') === false
                     && $key !== '$_SESSION'
-                    && !$existing_var_type->from_static_property
                 ) {
                     foreach ($existing_var_type->getAtomicTypes() as $atomic) {
                         if (!$existing_var_type->hasMixed()

src/Psalm/Internal/Type/SimpleAssertionReconciler.php

@@ -434,7 +434,6 @@ private static function reconcileIsset(
             && (!$did_remove_type || empty($existing_var_type->getAtomicTypes()))
             && $key
             && $code_location
-            && !$existing_var_type->from_static_property
         ) {
             self::triggerIssueForImpossible(
                 $existing_var_type,
@@ -459,7 +458,6 @@ private static function reconcileIsset(
         }
 
         $existing_var_type->from_property = false;
-        $existing_var_type->from_static_property = false;
         $existing_var_type->possibly_undefined = false;
         $existing_var_type->possibly_undefined_from_try = false;
         $existing_var_type->ignore_isset = false;

src/Psalm/Internal/Type/TypeExpander.php

@@ -78,7 +78,6 @@ public static function expandUnion(
         $fleshed_out_type->by_ref = $return_type->by_ref;
         $fleshed_out_type->initialized = $return_type->initialized;
         $fleshed_out_type->from_property = $return_type->from_property;
-        $fleshed_out_type->from_static_property = $return_type->from_static_property;
         $fleshed_out_type->had_template = $return_type->had_template;
         $fleshed_out_type->parent_nodes = $return_type->parent_nodes;
 

src/Psalm/Type/Union.php

@@ -56,16 +56,6 @@ class Union implements TypeNode
      */
     public $from_property = false;
 
-    /**
-     * Whether the type originated from *static* property
-     *
-     * Unlike non-static properties, static properties have no prescribed place
-     * like __construct() to be initialized in
-     *
-     * @var bool
-     */
-    public $from_static_property = false;
-
     /**
      * Whether the property that this type has been derived from has been initialized in a constructor
      *

tests/TypeReconciliation/IssetTest.php

@@ -1006,34 +1006,6 @@ function foo(array $test) : void {
                         echo $test[0];
                     }'
             ],
-            'issetOnStaticProperty' => [
-                '<?php
-                    class Singleton {
-                        private static self $instance;
-                        public function getInstance(): self {
-                            if (isset(self::$instance)) {
-                                return self::$instance;
-                            }
-                            return self::$instance = new self();
-                        }
-                        private function __construct() {}
-                    }
-                ',
-            ],
-            'negatedIssetOnStaticProperty' => [
-                '<?php
-                    class Singleton {
-                        private static self $instance;
-                        public function getInstance(): self {
-                            if (!isset(self::$instance)) {
-                                self::$instance = new self();
-                            }
-                            return self::$instance;
-                        }
-                        private function __construct() {}
-                    }
-                ',
-            ],
         ];
     }