Fix projectPosition in CARTESIAN coordinate system #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsherif
approved these changes
Mar 3, 2020
|
|
||
| if (offsetMode) { | ||
| const positionCommonSpace = viewport.projectPosition( | ||
| geospatialOrigin || shaderCoordinateOrigin |
There was a problem hiding this comment.
Might be missing a usage, but could this be simplified by having the value of geospatialOrigin default to shaderCoordinateOrigin instead of null? And then having getOffsetOrigin just return one offsetOrigin value.
There was a problem hiding this comment.
geospatialOrigin is always in lnglat and used later to calculate units per pixel. I'd leave it as is for now for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPU
projectPositionto GPUproject_positionparity was broken when using CARTESIAN coordinate system with Web Mercator projection (#4140).Change List
projectPositionandgetUniformsFromViewportnow share the same logic