Fix .gl and .state access #4338
Merged
+208
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
approved these changes
Mar 1, 2020
|
Thank you! Added 2D/3D test app. Feel free to merge. |
|
Lint is still failing |
|
This is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like a recent change "broke"
ArcGISDeckExternalRenderer, the 3D integration between deck.gl and ArcGIS.It's tricky to see the breakage because there is still no sample app, nor test, in the codebase. Plus, 3D integration was WIP, and things did not look correct, but at least it was possible to write apps that did not crash.
I am fine with merging this; to see the positive impact of this PR I am working on some pens that I will share once ready. Once things are looking good I will work on adding automated testing and a
pure-jssample app in the codebase, specific for 3D.