Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): include .css?url in assets field of manifest #17623

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(css): include .css?url in assets field of manifest #17623

wants to merge 2 commits into from

Conversation

sapphi-red
Copy link
Member

Description

fixes #17484

The manifest in the repro changes from

  "_stuff.js": {
    "file": "chunks/stuff.js",
    "name": "stuff",
    "assets": [
      "assets/text.txt"
    ]
  }

to

  "_stuff.js": {
    "file": "chunks/stuff.js",
    "name": "stuff",
    "assets": [
      "assets/text.txt",
      "assets/styles.css"
    ]
  },

@sapphi-red sapphi-red added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Jul 6, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jul 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS files are incorrectly excluded from assets array in manifest.json
1 participant
@sapphi-red