Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): handle nameless descture in function args #6489

Merged
merged 2 commits into from
Jan 13, 2022
Merged

fix(ssr): handle nameless descture in function args #6489

merged 2 commits into from
Jan 13, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 13, 2022

Description

Fix vitest-dev/vitest#261

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 13, 2022
@patak-dev patak-dev merged commit debc08d into main Jan 13, 2022
@patak-dev patak-dev deleted the fix/ssr-jsx-destructure branch January 13, 2022 08:47
antfu added a commit that referenced this pull request Jan 13, 2022
@antfu
fix(ssr): handle nameless descture in function args (#6489)
dd4c111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReferenceError: React is not defined
3 participants
@antfu @patak-dev @Niputi