fix: also handle toContain

vitest-dev · Feb 22, 2024 · cc3d708 · cc3d708
1 parent 34ac7d0
commit cc3d708
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/packages/expect/src/jest-expect.ts b/packages/expect/src/jest-expect.ts
@@ -209,6 +209,16 @@ export const JestChaiExpect: ChaiPlugin = (chai, utils) => {
         actual.value,
       )
     }
+    // handle simple case on our own using `this.assert` to include diff in error message
+    if (typeof actual === 'string' && typeof item === 'string') {
+      return this.assert(
+        actual.includes(item),
+        `expected #{this} to contain #{exp}`,
+        `expected #{this} not to contain #{exp}`,
+        item,
+        actual,
+      )
+    }
     // make "actual" indexable to have compatibility with jest
     if (actual != null && typeof actual !== 'string')
       utils.flag(this, 'object', Array.from(actual as Iterable<unknown>))

diff --git a/test/core/test/__snapshots__/jest-expect.test.ts.snap b/test/core/test/__snapshots__/jest-expect.test.ts.snap
@@ -320,11 +320,24 @@ exports[`toMatch/toContain diff 1`] = `
 - world
 + hellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohello",
   "expected": "world",
-  "message": "expected 'hellohellohellohellohellohellohellohe…' to match 'world'",
+  "message": "expected 'hellohellohellohellohellohellohellohe…' to contain 'world'",
 }
 `;
 
 exports[`toMatch/toContain diff 2`] = `
+{
+  "actual": "hellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohello",
+  "diff": "- Expected
++ Received
+
+- world
++ hellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohello",
+  "expected": "world",
+  "message": "expected 'hellohellohellohellohellohellohellohe…' to match 'world'",
+}
+`;
+
+exports[`toMatch/toContain diff 3`] = `
 {
   "actual": "hellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohellohello",
   "diff": "- Expected: 

diff --git a/test/core/test/jest-expect.test.ts b/test/core/test/jest-expect.test.ts
@@ -1086,6 +1086,7 @@ it('asymmetric matcher error', () => {
 })
 
 it('toMatch/toContain diff', () => {
+  snapshotError(() => expect('hello'.repeat(20)).toContain('world'))
   snapshotError(() => expect('hello'.repeat(20)).toMatch('world'))
   snapshotError(() => expect('hello'.repeat(20)).toMatch(/world/))
 })