Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite-node): mjs files watch not work #3982

Merged
merged 7 commits into from
Oct 3, 2023
Merged

fix(vite-node): mjs files watch not work #3982

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
14d0f8b
fix(vite-node): mjs files watch not work
Dunqing Aug 18, 2023
3ecf8c4
refactor: move
Dunqing Aug 18, 2023
79fee69
refactor: inline
Dunqing Aug 23, 2023
9ea6ad6
refactor: re-implement and add test cases
Dunqing Aug 23, 2023
b618acc
refactor: revert
Dunqing Aug 23, 2023
628591b
test: update timeout
Dunqing Aug 23, 2023
4f06a7f
test: update
Dunqing Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/vite-node/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { isAbsolute, join } from 'node:path'
import cac from 'cac'
import c from 'picocolors'
import { createServer } from 'vite'
Expand Down Expand Up @@ -74,11 +75,21 @@ async function run(files: string[], options: CliOptions = {}) {
cli.version(version).outputHelp()
process.exit(1)
}
const root = options.root || process.cwd()

const serverOptions = options.options
? parseServerOptions(options.options)
: {}

serverOptions.deps ??= {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work for an entry file. Here is how it's done in Vitest when using vite-node:

vitest/packages/vitest/src/node/config.ts

Line 17 in 41e828f

/^(?!.*(?:node_modules)).*\.mjs$/,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I should handle this in the vite node server? I'm not sure if my solution is correct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you should handle it in vite node server

if (serverOptions.deps.inline !== true) {
const entries = files.map((file) => {
return new RegExp(`[^${isAbsolute(file) ? file : join(root, file)}]`)
})
serverOptions.deps.inline ??= []
serverOptions.deps.inline.push(...entries)
}

const server = await createServer({
logLevel: 'error',
configFile: options.config,
Expand Down
Loading