fix default permissions and umask handling #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js731ca
force-pushed
the
default-permissions-and-umask
branch
from
dcea57f
to
c7dcda7
Compare
On linux files are usually created with permissions set to 666+umask, and folders with 777+umask. The codebase used to create files with 600 and folders with 700 *unless* a umask override was set in the configuration, then both files and folders would end up with 777+umask. This patch addresses this by setting the umask override on process level; Creating files with permissions set to 666 and folders set to 777 - with either the overridden or the system default umask applied. Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
js731ca
force-pushed
the
default-permissions-and-umask
branch
from
c7dcda7
to
a6f0a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On linux files are usually created with permissions set to 666+umask, and folders with 777+umask.
The codebase used to create files with 600 and folders with 700 unless a umask override was set in the configuration, then both files and folders would end up with 777+umask.
This patch addresses this by setting the umask override on process level; Creating files with permissions set to 666 and folders set to 777 - with either the overridden or the system default umask applied.