Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addstorage/rmstorage commands #61

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

pcercuei
Copy link
Contributor

These two commands allow to dynamically add and remove storages.

This is useful e.g. when the storage mountpoints and/or names are not known in advance.

This will be useful later to retrieve storage names in command
arguments.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
This pair of commands can be used to dynamically add storages at
runtime.

Examples:

umtprd '-cmd:addstorage:/tmp Tmp rw'
umtprd '-cmd:rmstorage:Tmp'

Use double-quotes when arguments have spaces in them:

umtprd '-cmd:addstorage:/path "My Path" rw,removable'
umtprd '-cmd:rmstorage:"My Path"'

Fixes viveris#29.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
@pcercuei
Copy link
Contributor Author

pcercuei commented Apr 1, 2021

Linux (nautilus) will need a F5 to refresh the list of volumes after a new storage volume has been added.
Windows 10 won't see the newly added volumes and will still display removed volumes even with a F5 refresh.
I wonder if there's something to do here.

Add guard in mtp_add_storage() to avoid the same storage from being
added twice.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
@jfdelnero
Copy link
Member

Thanks. About the initiators async events messages :

  • I didn't found the async event channel/messages specification so the implementation may have some issues.
  • The initiators seem/may be more or less buggy with async events : I managed to reproduce similar issues with an Android smartphone (Android 6)

Would be interesting to test a Microsoft Initiator to compare (a Windows Phone ?). And then get the expected event messages.

We should open an issue about this subject.

@jfdelnero jfdelnero merged commit beee656 into viveris:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants