Fix attached document deletion when deleting a page tree node

Backport of #1737 into v4.
vivid-planet · Feb 22, 2024 · 6af7d16 · 6af7d16
1 parent fdc7468
commit 6af7d16
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/clever-guests-sleep.md b/.changeset/clever-guests-sleep.md
@@ -0,0 +1,5 @@
+---
+"@comet/cms-api": patch
+---
+
+Fix attached document deletion when deleting a page tree node
diff --git a/packages/api/cms-api/src/page-tree/page-tree.service.ts b/packages/api/cms-api/src/page-tree/page-tree.service.ts
@@ -290,7 +290,8 @@ export class PageTreeService {
             if (attachedDocument.id) {
                 try {
                     const repository = this.em.getRepository(attachedDocument.type);
-                    await repository.removeAndFlush(attachedDocument);
+                    const document = await repository.findOneOrFail(attachedDocument.documentId);
+                    await repository.removeAndFlush(document);
                     await this.attachedDocumentsRepository.removeAndFlush(attachedDocument);
                 } catch {
                     throw new Error(`documentType ${attachedDocument.type} and documentId ${attachedDocument.id} cannot resolve`);