Make onDrop and onRemove optional as they are not needed when `re…

…adOnly` is set
vivid-planet · Jul 25, 2024 · c587461 · c587461
1 parent 490a895
commit c587461
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/packages/admin/admin/src/form/file/FileSelect.tsx b/packages/admin/admin/src/form/file/FileSelect.tsx
@@ -36,8 +36,8 @@ type ThemeProps = ThemedComponentBaseProps<{
 
 export type FileSelectProps<AdditionalValidFileValues = Record<string, unknown>> = {
     files: FileSelectItem<AdditionalValidFileValues>[];
-    onDrop: DropzoneOptions["onDrop"];
-    onRemove: (file: FileSelectItem<AdditionalValidFileValues>) => void;
+    onDrop?: DropzoneOptions["onDrop"];
+    onRemove?: (file: FileSelectItem<AdditionalValidFileValues>) => void;
     onDownload?: (file: FileSelectItem<AdditionalValidFileValues>) => void;
     disabled?: boolean;
     readOnly?: boolean;
@@ -128,7 +128,7 @@ export const FileSelect = <AdditionalValidFileValues = Record<string, unknown>,>
                                                   onDownload(file);
                                               }
                                     }
-                                    onClickDelete={readOnly ? undefined : () => onRemove(file)}
+                                    onClickDelete={readOnly || !onRemove ? undefined : () => onRemove(file)}
                                     {...slotProps?.fileListItem}
                                 />
                             ))}

diff --git a/storybook/src/docs/components/FileSelect/FileSelect.stories.tsx b/storybook/src/docs/components/FileSelect/FileSelect.stories.tsx
@@ -61,12 +61,6 @@ storiesOf("stories/components/FileSelect", module)
 
         return (
             <FileSelect
-                onDrop={(acceptedFiles, fileRejections) => {
-                    // Handle what happens with the dropped files
-                }}
-                onRemove={(file) => {
-                    // Handle remove
-                }}
                 onDownload={(file) => {
                     // Handle download
                 }}