Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COM-65: Improve layout selection UX in createColumnsBlock #1384

Merged
merged 15 commits into from
Dec 11, 2023
Merged

COM-65: Improve layout selection UX in createColumnsBlock #1384

merged 15 commits into from
Dec 11, 2023

Conversation

jennyvivid
Copy link
Contributor

@jennyvivid jennyvivid commented Nov 8, 2023 •
edited by johnnyomair
Loading

Hide select when there's only one layout for a specific number of columns.

Only one layout available (no select) layout-display
Multiple layouts available (with select) layout-dropdown layout-select

@jennyvivid jennyvivid self-assigned this Nov 8, 2023
@jennyvivid
Copy link
Contributor Author

Same thing here like with the alerts, I'm not quite sure how to correctly embed the theme colors here, so I've put the hex code for now.

@jennyvivid jennyvivid changed the title Create columns block improve UI COM-65: Create columns block improve UI Nov 13, 2023
jennyvivid and others added 3 commits November 13, 2023 15:48
@jennyvivid @jamesricky
Update hexcode value to value from theme
f194cbb 
Co-authored-by: Ricky James Smith <jamesricky@me.com>
@jennyvivid
Change changeset description to make clearer what changed where
82eb679
@jennyvivid @jamesricky
Add handling for empty layouts array
54953b2 
Co-authored-by: Ricky James Smith <jamesricky@me.com>
johnnyomair
johnnyomair requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating an additional FinalFormLayoutDisplay component, I'd move the logic into FinalFormLayoutSelect. This would also remove the duplicate styling I suppose.

.changeset/yellow-dots-listen.md Outdated Show resolved Hide resolved
@johnnyomair johnnyomair changed the title COM-65: Create columns block improve UI Improve layout selection UX in createColumnsBlock Dec 11, 2023
@vivid-planet vivid-planet deleted a comment from netlify bot Dec 11, 2023
@vivid-planet vivid-planet deleted a comment from netlify bot Dec 11, 2023
@johnnyomair johnnyomair merged commit 824ea66 into main Dec 11, 2023
10 checks passed
@johnnyomair johnnyomair deleted the createColumnsBlock-improve-UI branch December 11, 2023 12:00
@thomasdax98 thomasdax98 changed the title Improve layout selection UX in createColumnsBlock COM-65: Improve layout selection UX in createColumnsBlock Dec 11, 2023
VP-DS pushed a commit to VP-DS/comet that referenced this pull request Jan 12, 2024
@jennyvivid @jamesricky
@johnnyomair @VP-DS
Improve layout selection UX in createColumnsBlock (vivid-planet#1384)
4bfaa9b 
Hide select when there's only one layout for a specific number of
columns.

---------

Co-authored-by: Ricky James Smith <jamesricky@me.com>
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesricky jamesricky jamesricky approved these changes

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@jennyvivid jennyvivid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennyvivid @jamesricky @johnnyomair