Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #1422

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Version Packages #1422

merged 1 commit into from
Nov 28, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 22, 2023

@comet/admin@5.1.0

Minor Changes

  • 93b3d97: Extend error details in ErrorDialog

    Previously, uncaught errors in production environments would result in an "An error occurred" ErrorDialog, making the error difficult to debug.
    To improve the reproducibility of an error, we enrich the ErrorDialog with the following additionalInformation:

    • errorType: The type of the error, network or server error
    • httpStatus: The HTTP status of the request that failed
    • url: The URL where the error occurred
    • timestamp: The timestamp when the error occurred

    This information will be displayed in the ErrorDialog if no custom userMessage has been provided.
    In addition, a button has been added to allow this information to be copied to the clipboard.

Patch Changes

  • 21c3093: Fix saveAction in RouterPrompt of FinalForm

    The submit mutation wasn't correctly awaited if a FinalForm using an asynchronous validation was saved via the saveAction provided in the RouterPrompt.

    In practice, this affected FinalForms within an EditDialog. The EditDialog closed before the submission was completed. All changes were omitted. The result of the submission (fail or success) was never shown.

  • e33cd65: Fix EditDialog#onAfterSave not called on form submission

    The onAfterSave callback was only called when submitting a form inside an EditDialog by clicking the save button, but not when submitting the form by hitting the enter key.
    We fix this by adding the callback to the EditDialogFormApi and calling it after the form has been successfully submitted.

@comet/cms-admin@5.1.0

Patch Changes

  • e1d3f00: Prevent false positive save conflicts while editing documents (e.g. Page):

    • Stop checking for conflicts while saving is in progress
    • Ensure that all "CheckForChanges" polls are cleared
  • 6d69dfa: Fix issue in PixelImageBlock that caused the preview URLs for files without a file extension in their filename to be invalid

  • 21c3093: Improved the EditPageNode dialog ("Page Properties" dialog):

    • Execute the asynchronous slug validation less often (increased the debounce wait time from 200ms to 500ms)
    • Cache the slug validation results. Evict the cache on the initial render of the dialog

@comet/eslint-plugin@5.1.0

Minor Changes

  • ec0582e: Add new ESLint rule to enforce absolute imports when importing from other modules

    For instance, an import import { AThingInModuleA } from "../moduleA/AThingInModuleA" in module B needs to be imported as import { AThingInModuleA } from "@src/moduleA/AThingInModuleA".
    The default source root "./src" and alias "@src" can be changed via the rule's sourceRoot and sourceRootAlias options.
    This rule will be enforced by @comet/eslint-config in the next major release.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for comet-dxp-docs ready!

Name Link
🔨 Latest commit 6a0099f
🔍 Latest deploy log https://app.netlify.com/sites/comet-dxp-docs/deploys/6565cf3fad9fca000875ca01
😎 Deploy Preview https://deploy-preview-1422--comet-dxp-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for comet-admin ready!

Name Link
🔨 Latest commit 6a0099f
🔍 Latest deploy log https://app.netlify.com/sites/comet-admin/deploys/6565cf3fd5d9c500087b99a6
😎 Deploy Preview https://deploy-preview-1422--comet-admin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot force-pushed the changeset-release/main branch 9 times, most recently from fd8b568 to 50045c6 Compare November 28, 2023 10:36
@thomasdax98 thomasdax98 self-assigned this Nov 28, 2023
@thomasdax98 thomasdax98 merged commit 76325f4 into main Nov 28, 2023
8 checks passed
@thomasdax98 thomasdax98 deleted the changeset-release/main branch November 28, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant