Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@comet/admin@5.1.0
Minor Changes
93b3d97: Extend error details in
ErrorDialog
Previously, uncaught errors in production environments would result in an "An error occurred"
ErrorDialog
, making the error difficult to debug.To improve the reproducibility of an error, we enrich the
ErrorDialog
with the followingadditionalInformation
:errorType
: The type of the error, network or server errorhttpStatus
: The HTTP status of the request that failedurl
: The URL where the error occurredtimestamp
: The timestamp when the error occurredThis information will be displayed in the
ErrorDialog
if no customuserMessage
has been provided.In addition, a button has been added to allow this information to be copied to the clipboard.
Patch Changes
21c3093: Fix
saveAction
inRouterPrompt
ofFinalForm
The submit mutation wasn't correctly awaited if a
FinalForm
using an asynchronous validation was saved via thesaveAction
provided in theRouterPrompt
.In practice, this affected
FinalForm
s within anEditDialog
. TheEditDialog
closed before the submission was completed. All changes were omitted. The result of the submission (fail or success) was never shown.e33cd65: Fix
EditDialog#onAfterSave
not called on form submissionThe
onAfterSave
callback was only called when submitting a form inside anEditDialog
by clicking the save button, but not when submitting the form by hitting the enter key.We fix this by adding the callback to the
EditDialogFormApi
and calling it after the form has been successfully submitted.@comet/cms-admin@5.1.0
Patch Changes
e1d3f00: Prevent false positive save conflicts while editing documents (e.g.
Page
):6d69dfa: Fix issue in PixelImageBlock that caused the preview URLs for files without a file extension in their filename to be invalid
21c3093: Improved the EditPageNode dialog ("Page Properties" dialog):
@comet/eslint-plugin@5.1.0
Minor Changes
ec0582e: Add new ESLint rule to enforce absolute imports when importing from other modules
For instance, an import
import { AThingInModuleA } from "../moduleA/AThingInModuleA"
in moduleB
needs to be imported asimport { AThingInModuleA } from "@src/moduleA/AThingInModuleA"
.The default source root
"./src"
and alias"@src"
can be changed via the rule'ssourceRoot
andsourceRootAlias
options.This rule will be enforced by
@comet/eslint-config
in the next major release.