Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD Generator: Change the file ending of the private sibling GraphQL files from .gql.tsx to .gql.ts #1464

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

raphaelblum
Copy link
Contributor

No description provided.

johnnyomair
johnnyomair previously approved these changes Nov 30, 2023
nsams
nsams previously approved these changes Nov 30, 2023
@nsams
Copy link
Member

nsams commented Nov 30, 2023

is a changeset needed? Or is re-running generators a step you have to make for every minor upgrade anyway, and such a small change not worth mentioning in the changelog?

@raphaelblum raphaelblum dismissed stale reviews from nsams and johnnyomair via 0c1a6b7 December 7, 2023 14:15
@johnnyomair
Copy link
Collaborator

is a changeset needed? Or is re-running generators a step you have to make for every minor upgrade anyway, and such a small change not worth mentioning in the changelog?

I think it's okay to add a changeset

@johnnyomair johnnyomair changed the title change file ending of gql files in admin generator from tsx to ts CRUD Generator: Change the file ending of the private sibling GraphQL files from .gql.tsx to .gql.ts Dec 7, 2023
@johnnyomair johnnyomair merged commit 6fda5a5 into main Dec 7, 2023
10 checks passed
@johnnyomair johnnyomair deleted the gql-file-ending-ts branch December 7, 2023 14:47
VP-DS pushed a commit to VP-DS/comet that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants