Remove UserPermissions-Module #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyomair
previously approved these changes
Dec 6, 2023
johnnyomair
previously approved these changes
Dec 6, 2023
nsams
reviewed
Dec 6, 2023
packages/api/cms-api/src/mikro-orm/migrations/Migration20231206123505.ts
Outdated
Show resolved
Hide resolved
johnnyomair
dismissed
their stale review
We need to find a better way to delete the tables
fraxachun
force-pushed
the
remove-user-permissions-module
branch
from
b279ca4
to
e8bc685
Compare
johnnyomair
reviewed
Dec 12, 2023
packages/api/cms-api/src/mikro-orm/migrations/Migration20231206123505.ts
Outdated
Show resolved
Hide resolved
nsams
previously approved these changes
Dec 12, 2023
As it introduces incompatibilities and will be added when usable in the next Comet version
fraxachun
force-pushed
the
remove-user-permissions-module
branch
from
f1183e3
to
18ebe45
Compare
johnnyomair
approved these changes
Dec 13, 2023
nsams
approved these changes
Dec 13, 2023
VP-DS
pushed a commit
to VP-DS/comet
that referenced
this pull request
Jan 12, 2024
As it introduces incompatibilities and will be added when usable in the next Comet version
thomasdax98
added a commit
that referenced
this pull request
Feb 28, 2024
Backport by cherry-picking - #1327 - #1469 - #1479 - #1480 - relevant parts of #1487 --- <img width="1690" alt="Bildschirmfoto 2024-02-28 um 10 42 44" src="https://github.com/vivid-planet/comet/assets/13380047/9382ec1d-e57e-43e5-9370-43bbd62c2544"> --------- Co-authored-by: Tobias <34998750+Tobi98@users.noreply.github.com> Co-authored-by: Tobias Kuhn <tobias.kuhn@vivid-planet.com> Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com> Co-authored-by: Niko Sams <niko.sams@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it introduces incompatibilities and will be added when usable in the next Comet version