Add support for content translation in RTE #1587

VP-DS · 2024-01-17T11:01:25Z

COM-202 , COM-203

Test.Styling.+.Format.mov

Test custom inline styles:

Used customInlineStyles for RichTextBlock

export const RichTextBlock = createRichTextBlock({
    link: LinkBlock,
    rte: {
        customInlineStyles: {
            HIGHLIGHT: {
                label: "Highlight!",
                icon: Highlight,
                style: {
                    backgroundColor: "yellow",
                },
            },
        },
    },
});

Test.Custom.Inline.Style.+.Links.mov

⚠️ Note: The translation tool has to be smart enough to ignore the html tags!

External+News Link FinalFormInput disable Button

`dbe8ae3`

Screen.Recording.2024-01-31.at.15.44.28.mov

thomasdax98 · 2024-01-17T11:12:55Z

@VP-DS Thanks for the videos! Looks good

packages/admin/admin-rte/src/core/translation/xml/transformStateToXml.ts

.changeset/seven-sailor-sing.md

packages/admin/admin-rte/src/core/Controls/TranslationControls.tsx

packages/admin/admin-rte/src/core/translation/xml/transformStateToXml.ts

packages/admin/admin-rte/src/core/translation/ToolbarButton.tsx

packages/admin/admin-rte/src/core/translation/xml/translateAndTransformToState.ts

…ers back to text

…e string

packages/admin/admin-rte/package.json

…e html tag attributes

packages/admin/admin-rte/src/core/translation/htmlToState.ts

packages/admin/admin-rte/src/core/translation/stateToHtml.ts

packages/admin/admin-rte/src/core/translation/ToolbarButton.tsx

packages/admin/admin-rte/src/core/translation/xml/translateAndTransformToState.ts

packages/admin/admin-rte/package.json

packages/admin/admin-rte/src/core/translation/ToolbarButton.tsx

packages/admin/admin-rte/src/core/translation/htmlToState.ts

packages/admin/admin-rte/src/core/translation/stateToHtml.ts

packages/admin/admin-rte/src/core/translation/htmlToState.spec.ts

packages/admin/admin-rte/src/core/translation/stateToHtml.spec.ts

packages/admin/admin-rte/src/core/translation/stateToHtml.ts

packages/admin/admin-rte/src/core/translation/htmlToState.ts

…l function

…s required for the tests

…ml strings in the test

packages/admin/admin-rte/src/core/translation/ToolbarButton.tsx

packages/admin/admin-rte/src/core/translation/stateToHtml.spec.ts

thomasdax98 · 2024-02-20T09:26:11Z

And please fix the conflicts @VP-DS

… rte-translate-button

johnnyomair · 2024-02-20T11:21:48Z

@thomasdax98 please review, thanks!

packages/admin/admin-rte/src/core/translation/stateToHtml.ts

VP-DS added 4 commits January 17, 2024 11:22

Copy xml code from https://github.com/vivid-planet/comet/pull/1040/files

80a18ff

Add subscript and superscript support to xml code

0986c46

Add translation button to rte

ef6eda5

Add changelog md file

f5db0a1

auto-assign bot requested a review from johnnyomair January 17, 2024 11:01

auto-assign bot assigned VP-DS Jan 17, 2024

VP-DS requested review from nsams and thomasdax98 January 17, 2024 11:01

VP-DS mentioned this pull request Jan 17, 2024

Rte translate button + translation via xml transformation #1484

Closed

thomasdax98 reviewed Jan 17, 2024

View reviewed changes

packages/admin/admin-rte/src/core/translation/xml/transformStateToXml.ts Outdated Show resolved Hide resolved

johnnyomair reviewed Jan 24, 2024

View reviewed changes

johnnyomair changed the title ~~Rte translate button~~ Add support for content translation in RTE Jan 24, 2024

VP-DS added 4 commits January 26, 2024 10:22

Adjust changelog md file

d20b457

copy test .spec.ts files of copied xml code

75a6d3f

Only display translate button on rte block if enabled

5a9ac19

Add support for custom inline styles + decode escaped special charact…

dbe8ae3

…ers back to text

VP-DS requested review from thomasdax98 and johnnyomair January 29, 2024 14:01

Join and split by tag <split /> to send xml to translation as a singl…

f5bacdd

…e string

johnnyomair reviewed Jan 30, 2024

View reviewed changes

packages/admin/admin-rte/package.json Show resolved Hide resolved

packages/admin/admin-rte/package.json Show resolved Hide resolved

Remove xml code and use html packages instead

fb6ac0c

VP-DS force-pushed the rte-translate-button branch from ade924b to fb6ac0c Compare January 31, 2024 13:29

VP-DS requested a review from johnnyomair January 31, 2024 13:46

VP-DS mentioned this pull request Jan 31, 2024

Add content translation demo #1645

Closed

Replace uuid with number for link data array matching + shorten/renam…

a2a5e2e

…e html tag attributes

VP-DS force-pushed the rte-translate-button branch from 266e719 to a2a5e2e Compare February 1, 2024 08:16

johnnyomair reviewed Feb 6, 2024

View reviewed changes

packages/admin/admin-rte/src/core/translation/htmlToState.ts Show resolved Hide resolved

packages/admin/admin-rte/src/core/translation/stateToHtml.ts Show resolved Hide resolved

packages/admin/admin-rte/src/core/translation/ToolbarButton.tsx Outdated Show resolved Hide resolved

Add jest tests

19652ab

VP-DS requested a review from johnnyomair February 7, 2024 14:00

VP-DS commented Feb 8, 2024

View reviewed changes

johnnyomair requested changes Feb 13, 2024

View reviewed changes

VP-DS added 3 commits February 13, 2024 16:25

Use class instead of style for html span

3f85503

Rename linkDataList to entities for future support of a broader use case

0bbd007

Throw an error if an unsupported entityType is used in the stateToHtm…

d1be921

…l function

VP-DS force-pushed the rte-translate-button branch from e862a17 to d1be921 Compare February 14, 2024 07:26

VP-DS added 2 commits February 14, 2024 08:37

Reduce the options used in the spec.ts to only the minimum IRteOption…

7e5c676

…s required for the tests

Add trimHtml function which removes newlines and spaces to compare ht…

364ad7b

…ml strings in the test

VP-DS requested a review from johnnyomair February 14, 2024 07:55

johnnyomair reviewed Feb 20, 2024

View reviewed changes

packages/admin/admin-rte/src/core/translation/ToolbarButton.tsx Outdated Show resolved Hide resolved

packages/admin/admin-rte/src/core/translation/stateToHtml.spec.ts Show resolved Hide resolved

johnnyomair removed the request for review from nsams February 20, 2024 09:40

VP-DS added 2 commits February 20, 2024 10:42

Use comet ToolTip instead of mui

798c5a7

Merge remote-tracking branch 'origin/feature/translation-module' into…

453d449

… rte-translate-button

johnnyomair previously approved these changes Feb 20, 2024

View reviewed changes

thomasdax98 previously approved these changes Feb 20, 2024

View reviewed changes

packages/admin/admin-rte/src/core/translation/stateToHtml.ts Outdated Show resolved Hide resolved

Replace any with type used in draft-js-export-html file

ecd75ec

VP-DS dismissed stale reviews from thomasdax98 and johnnyomair via ecd75ec February 20, 2024 13:09

thomasdax98 approved these changes Feb 20, 2024

View reviewed changes

thomasdax98 requested a review from johnnyomair February 20, 2024 13:19

johnnyomair approved these changes Feb 20, 2024

View reviewed changes

johnnyomair merged commit f1fc9e2 into feature/translation-module Feb 20, 2024
2 checks passed

johnnyomair deleted the rte-translate-button branch February 20, 2024 13:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for content translation in RTE #1587

Add support for content translation in RTE #1587

VP-DS commented Jan 17, 2024 •

edited

Loading

thomasdax98 commented Jan 17, 2024 •

edited

Loading

thomasdax98 commented Feb 20, 2024

johnnyomair commented Feb 20, 2024

Add support for content translation in RTE #1587

Add support for content translation in RTE #1587

Conversation

VP-DS commented Jan 17, 2024 • edited Loading

Test custom inline styles:

⚠️ Note: The translation tool has to be smart enough to ignore the html tags!

dbe8ae3

thomasdax98 commented Jan 17, 2024 • edited Loading

thomasdax98 commented Feb 20, 2024

johnnyomair commented Feb 20, 2024

VP-DS commented Jan 17, 2024 •

edited

Loading

`dbe8ae3`

thomasdax98 commented Jan 17, 2024 •

edited

Loading