Automatically discover available permissions #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraxachun
force-pushed
the
user-permissions-permission-discovery
branch
from
3b6468e
to
1e8131e
Compare
fraxachun
force-pushed
the
user-permissions-permission-discovery
branch
from
1e8131e
to
0c0d506
Compare
fraxachun
changed the title
nsams
reviewed
Feb 15, 2024
packages/api/cms-api/src/user-permissions/user-permissions.service.ts
Outdated
Show resolved
Hide resolved
|
great! I think that is a huge simplification |
nsams
previously approved these changes
Feb 15, 2024
|
nsams
previously approved these changes
Feb 19, 2024
johnnyomair
reviewed
Feb 20, 2024
nsams
previously approved these changes
Feb 21, 2024
|
I added a commit which exports the permissions used in cms-api |
This reverts commit 6605d91.
nsams
previously approved these changes
Feb 22, 2024
johnnyomair
reviewed
Feb 22, 2024
packages/api/cms-api/src/user-permissions/user-permissions.types.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
|
johnnyomair
reviewed
Feb 22, 2024
packages/api/cms-api/src/user-permissions/user-permissions.types.ts
Outdated
Show resolved
Hide resolved
johnnyomair
reviewed
Feb 22, 2024
johnnyomair
changed the title
…es.ts Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
- `packageDimensions` was nullable, although the database fields aren't nullable (caused an DB error if null was saved) - Admin Generator (present and future) doesn't support nested fields (for future it is WIP, present will never get it) - Easy solution: remove it - #1729 will showcase nested fields and everything (as replacement for packageDimensions)
However, my opinion is that the cometPermissions-object as well as deprecating the availablePermissions-option would not be necessary. |
|
@nsams @johnnyomair Reverted the last commits |
johnnyomair
approved these changes
Feb 22, 2024
thomasdax98
pushed a commit
that referenced
this pull request
Feb 23, 2024
Adds dependency https://github.com/golevelup/nestjs/tree/master/packages/discovery We lose code completion in RequiredPermission-decorator and getPermissionsForUser as there are only strings but that's not a huge deal as the system gets much more flexible. --------- Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com> Co-authored-by: Ben-Ho <bh@vivid-planet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dependency https://github.com/golevelup/nestjs/tree/master/packages/discovery
We lose code completion in RequiredPermission-decorator and getPermissionsForUser as there are only strings but that's not a huge deals as the system gets much more flexible.