Refactor @comet/admin-icons generator to accept a broader variation of SVGs
#1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyomair
changed the title
@comet/admin-icons generator to accept a broader variation of SVGs
johnnyomair
reviewed
Feb 21, 2024
johnnyomair
approved these changes
Feb 22, 2024
thomasdax98
approved these changes
Feb 22, 2024
thomasdax98
pushed a commit
that referenced
this pull request
Feb 23, 2024
… of SVGs (#1732) COM-366 Change the icon generator to accept icons with more than one path, as well as circles etc. and more complex structures like: ``` <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="none" viewBox="0 0 16 16"> <g clip-path="url(#a)"> <path fill="#242424" fill-rule="evenodd" d="M7.529.401a.5.5 0 0 1 .275.082l.076.06 3.647 3.574a.5.5 0 0 1-.63.772l-.07-.058-3.501-3.43-5.99.015.003 5.968 7.474 7.475 5.994-5.994-1.578-1.681a.5.5 0 0 1-.038-.64l.06-.067a.5.5 0 0 1 .64-.038l.067.06 1.91 2.034a.5.5 0 0 1 .046.628l-.056.068-6.69 6.69a.5.5 0 0 1-.639.058l-.069-.057L.486 7.945a.5.5 0 0 1-.14-.274l-.007-.08L.335.918a.5.5 0 0 1 .41-.492l.09-.008L7.528.4ZM5 4a1 1 0 1 1 0 2 1 1 0 0 1 0-2Z" clip-rule="evenodd"/> </g> <defs> <clipPath id="a"> <path fill="#fff" d="M0 0h16v16H0z"/> </clipPath> </defs> </svg> ``` The new icons have the same structure as the input svg files but without the `fill` prop. All other props are kept. I tested resizing and coloring, both work. --------- Co-authored-by: Phillip Lechenauer <phillip.lechenauer@vivid-planet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COM-366
Change the icon generator to accept icons with more than one path, as well as circles etc. and more complex structures like:
The new icons have the same structure as the input svg files but without the
fillprop. All other props are kept.I tested resizing and coloring, both work.