Admin Stack: Show Prompt if navigating into a nested Stack, even if subRoutes would normally not show Prompt #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsams
force-pushed
the
stack-subroute-prompt
branch
from
48e482a
to
523446a
Compare
nsams
force-pushed
the
stack-subroute-prompt
branch
from
523446a
to
a38914c
Compare
…ubRoutes would normally not show Prompt
nsams
force-pushed
the
stack-subroute-prompt
branch
from
a38914c
to
15d1fcd
Compare
johnnyomair
reviewed
Jun 21, 2024
|
@thomasdax98 I believe this is necessary for the stable v7 release. |
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
johnnyomair
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bildschirmaufzeichnung.vom.2024-04-17.18.03.01.webm
This adds:
ForcePromptRoute, to be used like react-router Route, that also registers it's path in a new context created byRouterPromptPromptHandlercan now check if the navigating-to-url matches with a path from registeredForcePromptRouteAlso adjust
StackSwitch:ForcePromptRouteSwitchas that would only render the first matching route (but we needForcePromptRouteto always render so it can register)Switchby only rendering index if no other route matched