Remove clearable from color and time pickers
#1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrearutrecht
changed the title
clearable from time pickersclearable from color and time pickers
andrearutrecht
force-pushed
the
remove-clearable-from-pickers
branch
2 times, most recently
from
6d1b5cc
to
f413748
Compare
andrearutrecht
force-pushed
the
remove-clearable-from-pickers
branch
from
f413748
to
1a04615
Compare
|
@andrearutrecht is this ready for review? |
@johnnyomair No, it is still set to draft |
Then the review requests should be removed. Draft + review request = "It can't be merged like this, but I want your opinion on it anyway" Draft + no review request = "I'm still working on it" |
|
Oh, thank you for that info! I did not know. |
jamesricky
reviewed
Apr 23, 2024
storybook/src/docs/form/components/DateAndTimePickers/stories/DateTimePicker.stories.tsx
Outdated
Show resolved
Hide resolved
jamesricky
reviewed
Apr 23, 2024
jamesricky
approved these changes
Apr 24, 2024
johnnyomair
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clearableprop is removed from all pickers inadmin/admin-date-timeand fromColorPicker. All Pickers are nowclearableby default and only notclearablewhenrequiredis set.PR Checklist
Screenshots of Time and Date Pickers in Storybook to show default `clearable` behaviour:
Screenshots of Time and Date Pickers in Storybook to show `required` behaviour:
Screenshots of `ColorPicker` stories: