Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSelect styling adjustments #2301

Merged
merged 2 commits into from
Jul 22, 2024
Merged

FileSelect styling adjustments #2301

merged 2 commits into from
Jul 22, 2024

Conversation

jamesricky
Copy link
Contributor

@jamesricky jamesricky commented Jul 17, 2024 •
edited
Loading

Implement updated design to also support usage on content without white a background.

PR Checklist

  • Verify if the change requires a changeset. See CONTRIBUTING.md
  • Link to the respective task if one exists: COM-875
  • Provide screenshots/screencasts if the change contains visual changes
Previously Now
previously white background now white background
previously gray background now gray background

@jamesricky jamesricky self-assigned this Jul 17, 2024
johnnyomair
johnnyomair previously approved these changes Jul 18, 2024
View reviewed changes
@jamesricky
Add option to disable background in story
acc7e27
@jamesricky
Styling adjustments for file select components
8de8769 
Implement updated design to also support usage on content without white a background.
@jamesricky jamesricky force-pushed the file-select-styling-adjustments branch from d8e5b22 to 8de8769 Compare July 22, 2024 12:25
@jamesricky jamesricky changed the base branch from public-upload-file-endpoints to next July 22, 2024 12:25
@jamesricky jamesricky dismissed johnnyomair’s stale review July 22, 2024 12:25

The base branch was changed.

@jamesricky jamesricky changed the base branch from next to feature/file-upload July 22, 2024 12:25
@jamesricky jamesricky marked this pull request as ready for review July 22, 2024 12:25
@jamesricky jamesricky changed the title File select styling adjustments FileSelect styling adjustments Jul 22, 2024
@johnnyomair johnnyomair merged commit 2ab9abd into feature/file-upload Jul 22, 2024
3 checks passed
@johnnyomair johnnyomair deleted the file-select-styling-adjustments branch July 22, 2024 13:08
jamesricky added a commit that referenced this pull request Jul 24, 2024
@jamesricky
Remove cards after fixing styles in #2301
60ca358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@jamesricky jamesricky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesricky @johnnyomair