Rename public uploads to file uploads #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name "public uploads" was not fitting since the uploads can also be used for "private" uploads in the Admin. The feature was therefore renamed to "file uploads". This requires the following changes: - Use `FilesUploadModule` instead of `PublicUploadModule` - Use `FileUpload` instead of `PublicUpload` - Use `FileUploadsService` instead of `PublicUploadsService` - Change the upload URL from `/public-upload/files/upload` to `/files-uploads/upload`
johnnyomair
force-pushed
the
rename-public-uploads
branch
from
5211402
to
fb3b473
Compare
johnnyomair
commented
Jul 25, 2024
thomasdax98
previously approved these changes
Jul 25, 2024
1 task
Co-authored-by: Thomas Dax <thomas.dax@vivid-planet.com>
thomasdax98
previously approved these changes
Jul 25, 2024
nsams
previously approved these changes
Jul 25, 2024
thomasdax98
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name "public uploads" was not fitting since the uploads can also be used for "private" uploads in the Admin. The feature was therefore renamed to "file uploads".
This requires the following changes:
FilesUploadModuleinstead ofPublicUploadModuleFileUploadinstead ofPublicUploadFileUploadsServiceinstead ofPublicUploadsService/public-upload/files/uploadto/files-uploads/uploadPR Checklist