Update predefined pages #2550
Open
Update predefined pages #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return value isn't nullable due to using `findOneOrFail`.
Make sure that saving a predefined page document actually works.
We do this for the Admin Generator, so we should do it here as well.
Predefined pages aren't structured content.
johnnyomair
force-pushed
the
update-predefined-pages
branch
from
62bf9ee
to
5d7b864
Compare
|
I tried splitting the save mutation into a create and update mutation first, but this requires a change to DocumentInterface, so I reverted my change. Should we plan this for the future? |
johnnyomair
commented
Sep 23, 2024
| @Field(() => String, { nullable: true }) | ||
| @IsString() | ||
| @Field(() => PredefinedPageType, { nullable: true }) | ||
| @IsEnum(PredefinedPageType) | ||
| @IsOptional() |
There was a problem hiding this comment.
@nsams type can be both optional (not changed) and nullable (unset). Should I use @IsUndefinable and @IsNullable() instead? And should the TS type reflect that as well?
There was a problem hiding this comment.
yes, @IsOptional should not be used anymore. And in that case @IsUndefinable and @IsNullable() together are correct.
And should the TS type reflect that as well?
yes
There was a problem hiding this comment.
Fixed: be85243
|
@nsams @thomasdax98 it's probably best to review this on a commit basis. |
nsams
reviewed
Sep 27, 2024
thomasdax98
previously approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The predefined pages demo was in a bad shape: Loading/saving didn't work, the info tag didn't look right, etc. I've therefore updated the demo to reflect the latests changes/decisions made in the CRUD Generator. Notable changes:
typeRelated tasks and documents
https://vivid-planet.atlassian.net/browse/COM-1080
Further information
The implementation in Demo will be the basis for the docs, so please review carefully.