Dam file replacement on upload #2616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VP-DS
force-pushed
the
dam-file-replacement-on-upload
branch
from
ec0c09f
to
0bce94a
Compare
VP-DS
commented
Oct 10, 2024
| if (exifrSupportedMimetypes.includes(file.mimetype)) { | ||
| exifData = await exifr.parse(file.path); | ||
| } | ||
|
|
There was a problem hiding this comment.
above code is copied from upload function.
probably could put it into a helper function, but @thomasdax98 you wanted to keep them strictly separated, didn't you?
VP-DS
force-pushed
the
dam-file-replacement-on-upload
branch
from
0abbe3c
to
56012ca
Compare
VP-DS
force-pushed
the
dam-file-replacement-on-upload
branch
from
2fae1a2
to
59c32da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DAM files are often used in multiple locations, and manually updating each instance when replacing a file can be time-consuming. This Pull Request introduces a feature that allows you to replace DAM files seamlessly, without needing to manually update their usage locations.
Screenshots/screencasts
Image replacement with cache handling via contentHash in url
Image.replacing.with.caching.handled.mov
Test image url without optional contentHash
Test.url.with.optional.contentHash.removed.mov
Test url with optional contentHash removed
Test.url.with.optional.contentHash.removed.mov
Replacement dialog with cropping warning
Related tasks and documents
https://vivid-planet.atlassian.net/browse/COM-1133